Don't turn varchar vindex queries into IN#7268
Merged
systay merged 2 commits intovitessio:masterfrom Jan 8, 2021
Merged
Conversation
systay
changed the title
systay
force-pushed
the
fix-7254
branch
2 times, most recently
from
ce34a52 to
8783e33
Compare
we can't group together multiple varchar values into a IN query, because that forces use to compare varchar values on the vtgate level which we can't do correctly yet Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Jan 8, 2021
This was referenced Jan 8, 2021
Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't bundle together multiple varchar values and query the lookup vindexes using IN queries, because when we do, we then have to be able to compare varchar values at the vtgate level, and that is not always safe.
Fixes #7254